Re: [PATCH 1/4] t/unit-tests: handle dashes in test suite filenames

From: Patrick Steinhardt <ps@pks.im>
Date: Jan 16, 2025, 13:12 UTC
Message-ID: <Z4kFwynV3sQ5Plm8@pks.im>
In-Reply-To: <20250116104911.77405-2-kuforiji98@gmail.com>

On Thu, Jan 16, 2025 at 11:49:08AM +0100, Seyi Kuforiji wrote:

Show 5 quoted lines

> Adapt script to translate dashes (`-`) in test suite filenames to
> underscores (`_`) to ensure proper extraction of test function names.
> `generate-clar-decls.sh` does not pick up dashes in filenames such as
> `u-mem-pool.c`, which prevents the scripts from being run. This will be
> used by subsequent commits which follows the same construct.

Nit: it would be nice to provide a bit more context. What might not be
immediately be obvious is that the script extracts function signatures
that match a specific pattern derived from the unit test file's name,
so pointing that out would likely help.

Also note that "u-mem-pool.c" is not a script, so saying that these are getting run as scripts is misleading. I'd rather say something like "which prevents the unit tests declared in those suites from being executed".

The change itself looks good to me!

Patrick