Re: [PATCH v2 0/4] t/unit-tests: convert unit-tests to use clar

From: Patrick Steinhardt <ps@pks.im>
Date: Jan 17, 2025, 06:27 UTC
Message-ID: <Z4n4MxQ8FT-w6QLW@pks.im>
In-Reply-To: <20250116161559.91038-1-kuforiji98@gmail.com>

On Thu, Jan 16, 2025 at 05:15:55PM +0100, Seyi Kuforiji wrote:

Show 5 quoted lines

> Range-diff against v1:
> 1:  00bb4d2880 = 1:  00bb4d2880 t/unit-tests: handle dashes in test suite filenames
> 2:  59abf45f08 = 2:  59abf45f08 t/unit-tests: convert mem-pool test to use clar test framework
> 3:  6e01da141d = 3:  6e01da141d t/unit-tests: adapt priority queue test to use clar test framework
> 4:  b397a5f131 = 4:  b397a5f131 t/unit-tests: convert reftable tree test to use clar test framework

I think you passed wrong commit ranges for the range-diff :)

Anyway, I scanned through the changes and saw that all my feedback was addressed. I've got one more proposal for the first commit message, but other than that the series looks good to me.

Thanks!

Patrick