Re: [PATCH 4/6] verify_one_sparse(): drop unused repository parameter

From: Jeff King <peff@peff.net>
Date: Aug 20, 2022, 07:01 UTC
Message-ID: <YwCG1doiwSDOJuGK@coredump.intra.peff.net>
In-Reply-To: <cbbfbbdd-94de-d981-804b-fe199ca49754@github.com>

On Fri, Aug 19, 2022 at 03:04:19PM -0400, Derrick Stolee wrote:

Show 10 quoted lines

> On 8/19/2022 4:51 AM, Jeff King wrote:
> > This function has never used its repository parameter since it was
> > introduced in 9ad2d5ea71 (sparse-index: loose integration with
> > cache_tree_verify(), 2021-03-30). As that commit notes, it may
> > eventually be extended further, and that might require looking at a
> > repository struct. But it would be easy to add it back later if
> > necessary.
> 
> The good news is that 'struct index_state' now has a pointer to
> its repository, so we wouldn't need to add it back in.

Oh, right, that is even better. I think I have a few other patches in the pile that similarly remove repository pointers. When I'm writing them up, I'll check to see if they can use the same (much better) reasoning.

-Peff