git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/6] unused function parameter potpourri

From
Jeff King <peff@peff.net>
Date
Aug 19, 2022, 08:48 UTC
Message-ID
<Yv9Oay+tNqhLDqVl@coredump.intra.peff.net>

Here are a few small cleanups of unused function parameters. The first five just drop the unused parameters. These are all trivially correct, since otherwise the compiler would complain. But I tried to make sure that dropping was the right thing in each (rather than it being a bug where the parameter should have been used).

The final one just uses the parameters for an assertion, following a pattern we've used before.

I'll try to cc the individual authors for each patch.
  [1/6]: xdiff: drop unused mmfile parameters from xdl_do_histogram_diff()
  [2/6]: log-tree: drop unused commit param in remerge_diff()
  [3/6]: match_pathname(): drop unused "flags" parameter
  [4/6]: verify_one_sparse(): drop unused repository parameter
  [5/6]: reftable: drop unused parameter from reader_seek_linear()
  [6/6]: reflog: assert PARSE_OPT_NONEG in parse-options callbacks
 attr.c             | 2 +-
 builtin/reflog.c   | 4 ++++
 cache-tree.c       | 6 ++----
 dir.c              | 6 ++----
 dir.h              | 2 +-
 log-tree.c         | 5 ++---
 reftable/reader.c  | 6 +++---
 xdiff/xdiffi.c     | 2 +-
 xdiff/xdiffi.h     | 3 +--
 xdiff/xhistogram.c | 3 +--
 10 files changed, 18 insertions(+), 21 deletions(-)
-Peff
Next: Jeff King
Message 1 of 21 in “unused function parameter potpourri”
  1. 0/6 unused function parameter potpourriJeff King, Aug 19, 2022
  2. 1/6 xdiff: drop unused mmfile parameters from xdl_do_histogram_diff()Jeff King, Aug 19, 2022
  3. Phillip WoodAug 19, 2022
  4. Jeff KingAug 20, 2022
  5. 7/6 xdiff: drop unused mmfile parameters from xdl_do_patience_diff()Jeff King, Aug 20, 2022
  6. Phillip WoodAug 26, 2022
  7. 2/6 log-tree: drop unused commit param in remerge_diff()Jeff King, Aug 19, 2022
  8. Elijah NewrenAug 19, 2022
  9. Jeff KingAug 20, 2022
  10. 3/6 match_pathname(): drop unused "flags" parameterJeff King, Aug 19, 2022
  11. 4/6 verify_one_sparse(): drop unused repository parameterJeff King, Aug 19, 2022
  12. Derrick StoleeAug 19, 2022
  13. Jeff KingAug 20, 2022
  14. René ScharfeAug 20, 2022
  15. 4/6 verify_one_sparse(): drop unused repository parameterJeff King, Aug 20, 2022
  16. 5/6 reftable: drop unused parameter from reader_seek_linear()Jeff King, Aug 19, 2022
  17. Derrick StoleeAug 19, 2022
  18. Han-Wen NienhuysAug 22, 2022
  19. 6/6 reflog: assert PARSE_OPT_NONEG in parse-options callbacksJeff King, Aug 19, 2022
  20. Derrick StoleeAug 19, 2022
  21. Elijah NewrenAug 19, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.