[PATCH 4/6] verify_one_sparse(): drop unused repository parameter
- From
Jeff King <peff@peff.net>
- Date
- Aug 19, 2022, 08:51 UTC
- Message-ID
- <Yv9O+HDMLKglLcqY@coredump.intra.peff.net>
- In-Reply-To
- <Yv9Oay+tNqhLDqVl@coredump.intra.peff.net>
This function has never used its repository parameter since it was introduced in 9ad2d5ea71 (sparse-index: loose integration with cache_tree_verify(), 2021-03-30). As that commit notes, it may eventually be extended further, and that might require looking at a repository struct. But it would be easy to add it back later if necessary. In the mean time, dropping it makes the code shorter and appease -Wunused-parameter.
Signed-off-by: Jeff King <peff@peff.net> --- cache-tree.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/cache-tree.c b/cache-tree.c index 56db0b5026..c97111cccf 100644 --- a/cache-tree.c +++ b/cache-tree.c @@ -857,9 +857,7 @@ int cache_tree_matches_traversal(struct cache_tree *root, return 0; } -static void verify_one_sparse(struct repository *r, - struct index_state *istate, - struct cache_tree *it, +static void verify_one_sparse(struct index_state *istate, struct strbuf *path, int pos) { @@ -910,7 +908,7 @@ static int verify_one(struct repository *r, return 1; if (pos >= 0) { - verify_one_sparse(r, istate, it, path, pos); + verify_one_sparse(istate, path, pos); return 0; }
-- 2.37.2.928.g0821088f4a