git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 5/6] reftable: drop unused parameter from reader_seek_linear()

From
Derrick Stolee <derrickstolee@github.com>
Date
Aug 19, 2022, 19:06 UTC
Message-ID
<5f10be7e-424a-ed3b-bb77-75f1e026b2ae@github.com>
In-Reply-To
<Yv9P4O3WCrR9f9o2@coredump.intra.peff.net>
On 8/19/2022 4:54 AM, Jeff King wrote:
Show 9 quoted lines
> The reader code passes around a "struct reftable_reader" context
> variable. But the seek function doesn't need it; the table iterator we
> already get is sufficient.
> 
> Signed-off-by: Jeff King <peff@peff.net>
> ---
> One could argue that this is a method of a reftable_reader following the
> usual C object-oriented naming conventions, and thus should retain its
> first parameter, even if it isn't directly used.
> -static int reader_seek_linear(struct reftable_reader *r, struct table_iter *ti,
> +static int reader_seek_linear(struct table_iter *ti,
>  			      struct reftable_record *want)

If we wanted to make it seem more like it was a method of something, it now looks to operate on the table_iter, so the method name could change to something like "table_seek_linear()" which might satisfy both goals.

Thanks, -Stolee

Previous: Jeff KingNext: Han-Wen Nienhuys
Message 17 of 21 in “unused function parameter potpourri”
  1. 0/6 unused function parameter potpourriJeff King, Aug 19, 2022
  2. 1/6 xdiff: drop unused mmfile parameters from xdl_do_histogram_diff()Jeff King, Aug 19, 2022
  3. Phillip WoodAug 19, 2022
  4. Jeff KingAug 20, 2022
  5. 7/6 xdiff: drop unused mmfile parameters from xdl_do_patience_diff()Jeff King, Aug 20, 2022
  6. Phillip WoodAug 26, 2022
  7. 2/6 log-tree: drop unused commit param in remerge_diff()Jeff King, Aug 19, 2022
  8. Elijah NewrenAug 19, 2022
  9. Jeff KingAug 20, 2022
  10. 3/6 match_pathname(): drop unused "flags" parameterJeff King, Aug 19, 2022
  11. 4/6 verify_one_sparse(): drop unused repository parameterJeff King, Aug 19, 2022
  12. Derrick StoleeAug 19, 2022
  13. Jeff KingAug 20, 2022
  14. René ScharfeAug 20, 2022
  15. 4/6 verify_one_sparse(): drop unused repository parameterJeff King, Aug 20, 2022
  16. 5/6 reftable: drop unused parameter from reader_seek_linear()Jeff King, Aug 19, 2022
  17. Derrick StoleeAug 19, 2022
  18. Han-Wen NienhuysAug 22, 2022
  19. 6/6 reflog: assert PARSE_OPT_NONEG in parse-options callbacksJeff King, Aug 19, 2022
  20. Derrick StoleeAug 19, 2022
  21. Elijah NewrenAug 19, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.