Re: [PATCH 0/9] reducing memory allocations for v2 servers

From: Jeff King <peff@peff.net>
Date: Sep 14, 2021, 18:38 UTC
Message-ID: <YUDsJNV2mvKl5g29@coredump.intra.peff.net>
In-Reply-To: <xmqqy27z11gn.fsf@gitster.g>

On Tue, Sep 14, 2021 at 11:00:56AM -0700, Junio C Hamano wrote:

Show 10 quoted lines

> Jeff King <peff@peff.net> writes:
> 
> > While looking at [1], I noticed that v2 servers will read a few bits of
> > client input into strvecs. Even though we expect these to be small-ish,
> > there's nothing preventing a client from sending us a bunch of junk and
> > wasting memory.
> 
> The title of the topic says "reducing", but it smells more to me
> like this is about "limiting" allocations to protect ourselves.  Am
> I reading the series correctly?

Yeah, I think "limiting" is probably a better word. We will still allocate for ref-prefix, of course, but we'll limit the number of allocations. We did "reduce" the number of spots that allocate, since capabilities no longer do so. :)

But I think your understanding of the series is correct.

-Peff