Re: [PATCH 5/9] serve: provide "receive" function for session-id capability

From: Taylor Blau <me@ttaylorr.com>
Date: Sep 14, 2021, 16:55 UTC
Message-ID: <YUDT5bnnMNtkc3KK@nand.local>
In-Reply-To: <YUDAtbHcbv6zNFxe@coredump.intra.peff.net>

On Tue, Sep 14, 2021 at 11:33:09AM -0400, Jeff King wrote:

Show 5 quoted lines

> I had originally dropped has_capability() in a separate patch, to keep
> this one more readable. That breaks bisectability, but only with
> -Werror. I'm not sure where we should fall on that spectrum (I generally
> bisect with -Wno-error just because warnings may come and go when
> working with different compilers than what was normal at the time).

I tend to fall the same way, especially when bisecting things in ancient (to me) versions of Git where my current compiler complains. So I think the approach that you took here is just fine.

(This patch, as with all leading up to it, looks good to me.)

Thanks, Taylor

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.