Re: [PATCH v2 07/11] ls-refs: ignore very long ref-prefix counts

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Sep 15, 2021, 05:00 UTC
Message-ID: <CAPig+cQxSTzo0tCUEb3uMhyRLS0hyuOM5ksZyH+h2StFupQ9Yw@mail.gmail.com>
In-Reply-To: <YUE1hz/KKM0XebCP@coredump.intra.peff.net>

On Tue, Sep 14, 2021 at 7:51 PM Jeff King <peff@peff.net> wrote:

Show 14 quoted lines

> diff --git a/t/t5701-git-serve.sh b/t/t5701-git-serve.sh
> @@ -158,6 +158,37 @@ test_expect_success 'refs/heads prefix' '
> +test_expect_success 'ignore very large set of prefixes' '
> +       # generate a large number of ref-prefixes that we expect
> +       # to match nothing; the value here exceeds TOO_MANY_PREFIXES
> +       # from ls-refs.c.
> +       {
> +               echo command=ls-refs &&
> +               echo object-format=$(test_oid algo)
> +               echo 0001 &&
> +               perl -le "print \"ref-prefix refs/heads/\$_\" for (1..65536)" &&
> +               echo 0000
> +       } |
> +       test-tool pkt-line pack >in &&

Broken &&-chain in {...}.

(Granted, it doesn't matter in this case since the exit code gets lost down the pipe, but better to be consistent about it.)