git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Improved and extended t5404

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Nov 14, 2007, 22:01 UTC
Message-ID
<Pine.LNX.4.64.0711142159400.4362@racer.site>
In-Reply-To
<20071114203409.GD3973@steel.home>
Hi,
On Wed, 14 Nov 2007, Alex Riesen wrote:
Show 8 quoted lines
> Alex Riesen, Wed, Nov 14, 2007 20:45:22 +0100:
>
> > Well, I do not know it _should_ fail. Personally, I would not even 
> > care: I see no way to cover with just one exit code multiple failures. 
> > Some references were updated and I don't even know which. So I'd 
> > better check whatever exit code.
> 
> "I'd better check whatever was updated and damn the exit code"

My point was: why not check both? I mean, you know if it fails in your case. Better to test for this behaviour, than to have it succeed here, but fail there.

It's really easy, too: if it does not succeed, it fails. Just test for it.

Ciao, Dscho "consistency is good"

Previous: Alex RiesenNext: Jeff King
Message 16 of 22 in “Add a test checking if send-pack updated local tracking branches correctly”
  1. Add a test checking if send-pack updated local tracking branches correctlyAlex Riesen, Nov 12, 2007
  2. Update the tracking references only if they were succesfully updated on remoteAlex Riesen, Nov 12, 2007
  3. Jeff KingNov 13, 2007
  4. Alex RiesenNov 13, 2007
  5. Add a test for deleting remote branchesAlex Riesen, Nov 13, 2007
  6. Improved and extended t5404Alex Riesen, Nov 13, 2007
  7. Jeff KingNov 13, 2007
  8. Jeff KingNov 15, 2007
  9. Add test that checks diverse aspects of updating remote and tracking branchesAlex Riesen, Nov 15, 2007
  10. Junio C HamanoNov 14, 2007
  11. Alex RiesenNov 14, 2007
  12. Junio C HamanoNov 14, 2007
  13. Johannes SchindelinNov 14, 2007
  14. Alex RiesenNov 14, 2007
  15. Alex RiesenNov 14, 2007
  16. Johannes SchindelinNov 14, 2007
  17. Jeff KingNov 15, 2007
  18. Jeff KingNov 15, 2007
  19. Junio C HamanoNov 15, 2007
  20. Junio C HamanoNov 14, 2007
  21. Add test that checks diverse aspects of updating remote and tracking branchesAlex Riesen, Nov 14, 2007
  22. Junio C HamanoNov 14, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.