From: Johannes Schindelin Date: Wed, 14 Nov 2007 22:01:40 GMT Subject: Re: [PATCH] Improved and extended t5404 Message-ID: In-Reply-To: <20071114203409.GD3973@steel.home> Hi, On Wed, 14 Nov 2007, Alex Riesen wrote: > Alex Riesen, Wed, Nov 14, 2007 20:45:22 +0100: > > > Well, I do not know it _should_ fail. Personally, I would not even > > care: I see no way to cover with just one exit code multiple failures. > > Some references were updated and I don't even know which. So I'd > > better check whatever exit code. > > "I'd better check whatever was updated and damn the exit code" My point was: why not check both? I mean, you know if it fails in your case. Better to test for this behaviour, than to have it succeed here, but fail there. It's really easy, too: if it does not succeed, it fails. Just test for it. Ciao, Dscho "consistency is good"