Re: [PATCH] Improved and extended t5404
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 14, 2007, 00:02 UTC
- Message-ID
- <7vmythr8xf.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <20071113230234.GI3268@steel.home>
Alex Riesen <raa.lkml@gmail.com> writes:
> Ignore exit code of git push in t5404, as it is not relevant for the > test
This proposed log message solicits a "Huh? -- Since when ignoring exit code is an improvement?" reaction. If this push is expected to error out, then wouldn't you want to make sure it errors out as expected? If the problem is that the exit status is unreliable, maybe we need to make it reliable instead?