Re: [PATCH v6 10/13] convert: generate large test files only once

From: Lars Schneider <larsxschneider@gmail.com>
Date: Aug 25, 2016, 19:54 UTC
Message-ID: <E574E25A-F87F-416C-88E5-E3CE1F6B54D0@gmail.com>
In-Reply-To: <CAGZ79kZ5utc+0iXKPh=tu4rD9H6+AKZmc08_jLxQhgiuFUA+Yw@mail.gmail.com>

Show 10 quoted lines

> On 25 Aug 2016, at 21:17, Stefan Beller <sbeller@google.com> wrote:
> 
>> On Thu, Aug 25, 2016 at 4:07 AM,  <larsxschneider@gmail.com> wrote:
>> From: Lars Schneider <larsxschneider@gmail.com>
>> 
>> Generate more interesting large test files
> 
> How are the large test files more interesting?
> (interesting in the notion of covering more potential bugs?
> easier to debug? better to maintain, or just a pleasant read?)

The old large test file was 1MB of zeros and 1 byte with a one, repeated 2048 times.

Since the filter uses 64k packets we would test a large number of equally looking packets.

That's why I thought the pseudo random content is more interesting.

Show 5 quoted lines

>> with pseudo random characters
>> in between and reuse these test files in multiple tests. Run tests
>> formerly marked as EXPENSIVE every time but with a smaller data set.
> 
> Sounds good to me.

Thank you. Lars