Re: [PATCH v6 03/13] pkt-line: add packet_write_fmt_gently()
- From
Stefan Beller <sbeller@google.com>
- Date
- Aug 25, 2016, 18:12 UTC
- Message-ID
- <CAGZ79kbEoYVM_+MWkajT2pHN1OKZXATe5d+Dv_uSJ7dyPGxUeg@mail.gmail.com>
- In-Reply-To
- <20160825110752.31581-4-larsxschneider@gmail.com>
Show 8 quoted lines
> +int packet_write_fmt_gently(int fd, const char *fmt, ...)
> +{
> + static struct strbuf buf = STRBUF_INIT;
> + va_list args;
> +
> + strbuf_reset(&buf);
> + va_start(args, fmt);
> + format_packet(&buf, fmt, args);format_packet also takes care of tracing the contents, which was a bit unexpected to me. Do we also want to trace failure?