Re: [PATCH v2 05/11] t0027: make hash size independent'

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Aug 19, 2018, 22:10 UTC
Message-ID: <CAPig+cTTmOw-d7umES9p2xv4uCkjTnNtjTni_DaVFKbhc8WTgA@mail.gmail.com>
In-Reply-To: <20180819215732.GJ70480@genre.crustytoothpaste.net>

On Sun, Aug 19, 2018 at 5:57 PM brian m. carlson <sandals@crustytoothpaste.net> wrote:

Show 14 quoted lines

> On Sun, Aug 19, 2018 at 04:10:21PM -0400, Eric Sunshine wrote:
> > On Sun, Aug 19, 2018 at 1:54 PM brian m. carlson
> > > -       tr '\015\000abcdef0123456789' QN00000000000000000 <"$2" >"$exp" &&
> > > +       tr '\015\000abcdef0123456789' QN00000000000000000 <"$2" >"$exp+" &&
> >
> > My immediate thought upon reading this was whether "+" is valid in
> > Windows filenames. Apparently, it is, but perhaps (if you re-roll) it
> > would make sense to use a character less likely to cause brain
> > hiccups; for instance, "exp0'.
>
> The reason I picked that is that we use it quite a bit in the Makefile,
> so it seemed like an obvious choice for a temporary file name.  If you
> feel strongly I can pick something else, but I thought it would be
> reasonably intuitive for other developers.  Maybe I was wrong, though.

I don't feel strongly about it. My brain tripped over it probably because it's not an idiom in Git tests. In fact, I see just one place where "+" has been used like this, in t6026.