git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 03/11] t0000: update tests for SHA-256

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Aug 19, 2018, 20:01 UTC
Message-ID
<CAPig+cSRYZ6X-71oZ473g_pChcfNcFyFPO3e8YoJmYyg+KwoyQ@mail.gmail.com>
In-Reply-To
<20180819175351.449973-4-sandals@crustytoothpaste.net>

On Sun, Aug 19, 2018 at 1:54 PM brian m. carlson <sandals@crustytoothpaste.net> wrote:

Show 14 quoted lines
> Test t0000 tests the "basics of the basics" and as such, checks that we
> have various fixed hard-coded object IDs.  The tests relying on these
> assertions have been marked with the SHA1 prerequisite, as they will
> obviously not function in their current form with SHA-256.
>
> Use the test_oid helper to update these assertions and provide values
> for both SHA-1 and SHA-256.
> [...]
> Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
> ---
> diff --git a/t/t0000-basic.sh b/t/t0000-basic.sh
> @@ -868,8 +870,9 @@ test_expect_success 'writing tree out with git write-tree' '
> +test_expect_success 'validate object ID of a known tree' '
> +echo $tree &&
Debugging gunk?
> +       test "$tree" = $(test_oid simpletree)

If test_oid() fails to find key "simpletree", this expression will be invalid. Therefore, it probably would be a good idea to quote the $(test_oid ...) invocation.

Show 13 quoted lines
> @@ -911,17 +914,18 @@ test_expect_success 'showing stage with git ls-files --stage' '
> +test_expect_success 'validate git ls-files output for a known tree' '
> +       cat >expected <<-EOF &&
> +       100644 $(test_oid path0f) 0     path0
> +       120000 $(test_oid path0s) 0     path0sym
> +       100644 $(test_oid path2f) 0     path2/file2
> +       120000 $(test_oid path2s) 0     path2/file2sym
> +       100644 $(test_oid path3f) 0     path3/file3
> +       120000 $(test_oid path3s) 0     path3/file3sym
> +       100644 $(test_oid subp3f) 0     path3/subp3/file3
> +       120000 $(test_oid subp3s) 0     path3/subp3/file3sym
>         EOF
> +       cat expected &&
Debugging gunk?
>         test_cmp expected current
>  '
Previous: brian m. carlsonNext: brian m. carlson
Message 10 of 24 in “Hash-independent tests (part 3)”
  1. 00/11 Hash-independent tests (part 3)brian m. carlson, Aug 19, 2018
  2. 01/11 t: add tool to translate hash-related valuesbrian m. carlson, Aug 19, 2018
  3. Eric SunshineAug 19, 2018
  4. brian m. carlsonAug 19, 2018
  5. Eric SunshineAug 19, 2018
  6. brian m. carlsonAug 19, 2018
  7. 02/11 t0000: use hash translation tablebrian m. carlson, Aug 19, 2018
  8. Eric SunshineAug 19, 2018
  9. 03/11 t0000: update tests for SHA-256brian m. carlson, Aug 19, 2018
  10. Eric SunshineAug 19, 2018
  11. brian m. carlsonAug 19, 2018
  12. 04/11 t0002: abstract away SHA-1 specific constantsbrian m. carlson, Aug 19, 2018
  13. Eric SunshineAug 19, 2018
  14. 05/11 t0027: make hash size independentbrian m. carlson, Aug 19, 2018
  15. Eric SunshineAug 19, 2018
  16. brian m. carlsonAug 19, 2018
  17. Eric SunshineAug 19, 2018
  18. Torsten BögershausenAug 20, 2018
  19. 06/11 t0064: make hash size independentbrian m. carlson, Aug 19, 2018
  20. 07/11 t1006: make hash size independentbrian m. carlson, Aug 19, 2018
  21. 08/11 t1400: switch hard-coded object ID to variablebrian m. carlson, Aug 19, 2018
  22. 09/11 t1405: make hash size independentbrian m. carlson, Aug 19, 2018
  23. 10/11 t1406: make hash-size independentbrian m. carlson, Aug 19, 2018
  24. 11/11 t1407: make hash size independentbrian m. carlson, Aug 19, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.