Re: [PATCH v2 05/11] t0027: make hash size independent'

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Aug 19, 2018, 21:57 UTC
Message-ID: <20180819215732.GJ70480@genre.crustytoothpaste.net>
In-Reply-To: <CAPig+cS6Z+U-Z26m-eW-JX5D29ONSb_Zzur2fvWGb_ZMbmF4UQ@mail.gmail.com>

On Sun, Aug 19, 2018 at 04:10:21PM -0400, Eric Sunshine wrote:

Show 16 quoted lines

> On Sun, Aug 19, 2018 at 1:54 PM brian m. carlson
> <sandals@crustytoothpaste.net> wrote:
> > We transform various object IDs into all-zero object IDs for comparison.
> > Adjust the length as well so that this works for all hash algorithms.
> >
> > Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
> > ---
> > diff --git a/t/t0027-auto-crlf.sh b/t/t0027-auto-crlf.sh
> > @@ -15,8 +15,9 @@ compare_ws_file () {
> > -       tr '\015\000abcdef0123456789' QN00000000000000000 <"$2" >"$exp" &&
> > +       tr '\015\000abcdef0123456789' QN00000000000000000 <"$2" >"$exp+" &&
> 
> My immediate thought upon reading this was whether "+" is valid in
> Windows filenames. Apparently, it is, but perhaps (if you re-roll) it
> would make sense to use a character less likely to cause brain
> hiccups; for instance, "exp0'.

The reason I picked that is that we use it quite a bit in the Makefile, so it seemed like an obvious choice for a temporary file name. If you feel strongly I can pick something else, but I thought it would be reasonably intuitive for other developers. Maybe I was wrong, though.

-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204