Re: [PATCH v2 05/11] t0027: make hash size independent'

From: Torsten Bögershausen <tboegi@web.de>
Date: Aug 20, 2018, 14:29 UTC
Message-ID: <31634401-f889-c551-4232-4745b9ccce44@web.de>
In-Reply-To: <CAPig+cTTmOw-d7umES9p2xv4uCkjTnNtjTni_DaVFKbhc8WTgA@mail.gmail.com>

On 20.08.18 00:10, Eric Sunshine wrote:

Show 21 quoted lines

> On Sun, Aug 19, 2018 at 5:57 PM brian m. carlson
> <sandals@crustytoothpaste.net> wrote:
>> On Sun, Aug 19, 2018 at 04:10:21PM -0400, Eric Sunshine wrote:
>>> On Sun, Aug 19, 2018 at 1:54 PM brian m. carlson
>>>> -       tr '\015\000abcdef0123456789' QN00000000000000000 <"$2" >"$exp" &&
>>>> +       tr '\015\000abcdef0123456789' QN00000000000000000 <"$2" >"$exp+" &&
>>>
>>> My immediate thought upon reading this was whether "+" is valid in
>>> Windows filenames. Apparently, it is, but perhaps (if you re-roll) it
>>> would make sense to use a character less likely to cause brain
>>> hiccups; for instance, "exp0'.
>>
>> The reason I picked that is that we use it quite a bit in the Makefile,
>> so it seemed like an obvious choice for a temporary file name.  If you
>> feel strongly I can pick something else, but I thought it would be
>> reasonably intuitive for other developers.  Maybe I was wrong, though.
> 
> I don't feel strongly about it. My brain tripped over it probably
> because it's not an idiom in Git tests. In fact, I see just one place
> where "+" has been used like this, in t6026.
>

Probably "tmp" is a better name than "exp+" (Why the '+' ? Is it better that the non-'+' ?)

Anyway, If we re-order a little bit, can we use a simple '|' instead ?

tr '\015\000abcdef0123456789' QN00000000000000000 <"$2" |
	sed -e "s/0000+/$ZERO_OID/"               >"$exp" &&
tr '\015\000abcdef0123456789' QN00000000000000000 <"$3" >"$act" &&