Re: [PATCH v2 03/11] t0000: update tests for SHA-256

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Aug 19, 2018, 21:53 UTC
Message-ID: <20180819215318.GI70480@genre.crustytoothpaste.net>
In-Reply-To: <CAPig+cSRYZ6X-71oZ473g_pChcfNcFyFPO3e8YoJmYyg+KwoyQ@mail.gmail.com>

On Sun, Aug 19, 2018 at 04:01:05PM -0400, Eric Sunshine wrote:

Show 7 quoted lines

> On Sun, Aug 19, 2018 at 1:54 PM brian m. carlson
> > diff --git a/t/t0000-basic.sh b/t/t0000-basic.sh
> > @@ -868,8 +870,9 @@ test_expect_success 'writing tree out with git write-tree' '
> > +test_expect_success 'validate object ID of a known tree' '
> > +echo $tree &&
> 
> Debugging gunk?

Yup.  Will fix both.

Show 5 quoted lines

> > +       test "$tree" = $(test_oid simpletree)
> 
> If test_oid() fails to find key "simpletree", this expression will be
> invalid. Therefore, it probably would be a good idea to quote the
> $(test_oid ...) invocation.

Good idea.

-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204