Re: [PATCH v2 4/7] config: add --fixed-value option, un-implemented

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Nov 25, 2020, 17:28 UTC
Message-ID: <CAPig+cTQMCho=wFHhg-ACrP2oOEQwBHnfmV-Rk1vARpF2Fafng@mail.gmail.com>
In-Reply-To: <91af356f-d0a0-1149-15dc-32da803ac6d9@gmail.com>

On Wed, Nov 25, 2020 at 9:09 AM Derrick Stolee <stolee@gmail.com> wrote:

Show 9 quoted lines

> On 11/23/2020 5:41 PM, Junio C Hamano wrote:
> > Update the document and help text with s/value_regex/value_pattern/
> > and say "use value_pattern as a fixed string, not an extended regexp",
> > perhaps?
>
> If I go about changing all documentation and error messages to say
> "value_pattern" instead of "value_regex", should I also update the uses
> in the *.po translation files? Or, should I leave them unmodified to
> trigger manual intervention by the translators?

A minor request: If you are going to put in the work to make that substitution, perhaps change it to "value-pattern" rather than "value_pattern" since a hyphen is more common in documentation for this sort of thing than underscore.