Re: [PATCH v2 5/7] config: plumb --fixed-value into config API
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Nov 24, 2020, 00:52 UTC
- Message-ID
- <CAPig+cR_FBT+kYPW2pGJmHCVFUB=cC=Z8DfaE+R4Oy5iabnr0g@mail.gmail.com>
- In-Reply-To
- <20201123222123.GE499823@google.com>
On Mon, Nov 23, 2020 at 5:22 PM Emily Shaffer <emilyshaffer@google.com> wrote:
Show 5 quoted lines
> On Mon, Nov 23, 2020 at 04:05:05PM +0000, Derrick Stolee via GitGitGadget wrote: > > + printf "fixed.test=bogus\n" >expect && > It is jarring to me to see a printf here when everywhere else we use > heredocs. 'git grep' tells me it's not unheard of, but it looks like > those are cases where the whole file doesn't use heredocs.
For creating a one-line file, the verbosity of a here-doc may be overkill. At any rate, `echo` would be more idiomatic than `printf`:
echo "fixed.test=bogus" >expect &&
(Though, this alone is likely not worth a re-roll.)