Re: [PATCH v3 2/8] config: replace 'value_regex' with 'value_pattern'

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Nov 25, 2020, 22:50 UTC
Message-ID: <CAPig+cRL1FksVbS7jN5s=BDm-Wyx7ABo+h=EC2-3bw7Lkp2WHg@mail.gmail.com>
In-Reply-To: <f135b001ad911c079b0754c61e2179277ce37e0f.1606342377.git.gitgitgadget@gmail.com>

On Wed, Nov 25, 2020 at 5:13 PM Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com> wrote:

Show 10 quoted lines

> [...]
> For documentation, use 'value-pattern' which is better punctuation. This
> affects Documentation/git-config.txt and the usage in builtin/config.c,
> which was already mixed between 'value_regex' and 'value-regex'.
> [...]
> Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
> ---
> diff --git a/Documentation/git-config.txt b/Documentation/git-config.txt
> +'git config' [<file-option>] [--type=<type>] [--show-origin] [--show-scope] [-z|--null] [--name-only] --get-regexp name_regex [value-pattern]
>  'git config' [<file-option>] --rename-section old_name new_name

A mini-project for someone to tackle some day would be to replace the remaining underscores with hyphens in the documentation, such as the above "name_regex", "old_name", "new_name". That's outside the scope of this series, though, and can easily be done at any time.