git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] fix global bash variable leak on __gitcompappend

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Apr 9, 2015, 19:26 UTC
Message-ID
<CAPig+cTE+UbNaY3rewqCFjZW7nAYOTP167W3Bhp4AEZoVBt0tA@mail.gmail.com>
In-Reply-To
<CAOsHV+tCHrbmapXU+eei7v1jfiwdpK8jT+ue=kb_dm9nDXtq_Q@mail.gmail.com>
On Thu, Apr 9, 2015 at 9:52 AM, Marcio Almada <marcio.web2@gmail.com> wrote:
Show 9 quoted lines
> 2015-04-09 0:56 GMT-03:00 Junio C Hamano <gitster@pobox.com>:
>> "Márcio Almada" <marcio.web2@gmail.com> writes:
>>>  contrib/completion/git-completion.bash | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> Nicely found and corrected.  Please sign-off your patch and Cc area
>> experts if you can find them (I'll do that this time for you).
>
> Ok, I'll remember this next time. Thanks for your incredible work here.
Junio's implication was that you should reply to his message with:
    Signed-off-by: Your Name <your@email>
Or re-send the patch with your sign-off added.
Previous: Marcio Almada
Message 6 of 6 in “fix global bash variable on __gitcompappend”
  1. fix global bash variable on __gitcompappendMárcio Almada, Apr 8, 2015
  2. fix global bash variable leak on __gitcompappendMárcio Almada, Apr 8, 2015
  3. Junio C HamanoApr 9, 2015
  4. SZEDER GáborApr 9, 2015
  5. Marcio AlmadaApr 9, 2015
  6. Eric SunshineApr 9, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.