Re: [PATCH] fix global bash variable leak on __gitcompappend

From: Marcio Almada <marcio.web2@gmail.com>
Date: Apr 9, 2015, 13:52 UTC
Message-ID: <CAOsHV+tCHrbmapXU+eei7v1jfiwdpK8jT+ue=kb_dm9nDXtq_Q@mail.gmail.com>
In-Reply-To: <xmqqiod6ar9v.fsf@gitster.dls.corp.google.com>

2015-04-09 0:56 GMT-03:00 Junio C Hamano <gitster@pobox.com>:

Show 11 quoted lines

> "Márcio Almada" <marcio.web2@gmail.com> writes:
>
>> ---
>>  contrib/completion/git-completion.bash | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Nicely found and corrected.  Please sign-off your patch and Cc area
> experts if you can find them (I'll do that this time for you).
>
> Thanks.
>

Ok, I'll remember this next time. Thanks for your incredible work here.

Show 14 quoted lines

>>
>> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
>> index 661a829..1620546 100644
>> --- a/contrib/completion/git-completion.bash
>> +++ b/contrib/completion/git-completion.bash
>> @@ -186,7 +186,7 @@ fi
>>
>>  __gitcompappend ()
>>  {
>> -     local i=${#COMPREPLY[@]}
>> +     local x i=${#COMPREPLY[@]}
>>       for x in $1; do
>>               if [[ "$x" == "$3"* ]]; then
>>                       COMPREPLY[i++]="$2$x$4"