Re: [PATCH] fix global bash variable leak on __gitcompappend
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 9, 2015, 03:56 UTC
- Message-ID
- <xmqqiod6ar9v.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <1428471958-12339-2-git-send-email-marcio3w@gmail.com>
"Márcio Almada" <marcio.web2@gmail.com> writes:
> --- > contrib/completion/git-completion.bash | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Nicely found and corrected. Please sign-off your patch and Cc area experts if you can find them (I'll do that this time for you).
Thanks.
Show 14 quoted lines
>
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index 661a829..1620546 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -186,7 +186,7 @@ fi
>
> __gitcompappend ()
> {
> - local i=${#COMPREPLY[@]}
> + local x i=${#COMPREPLY[@]}
> for x in $1; do
> if [[ "$x" == "$3"* ]]; then
> COMPREPLY[i++]="$2$x$4"