git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] fix global bash variable leak on __gitcompappend

From
Márcio Almada <marcio.web2@gmail.com>
Date
Apr 8, 2015, 05:45 UTC
Message-ID
<1428471958-12339-2-git-send-email-marcio3w@gmail.com>
In-Reply-To
<1428471958-12339-1-git-send-email-marcio3w@gmail.com>
---
 contrib/completion/git-completion.bash | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 661a829..1620546 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -186,7 +186,7 @@ fi
 
 __gitcompappend ()
 {
-	local i=${#COMPREPLY[@]}
+	local x i=${#COMPREPLY[@]}
 	for x in $1; do
 		if [[ "$x" == "$3"* ]]; then
 			COMPREPLY[i++]="$2$x$4"
-- 
1.9.3
Previous: Márcio AlmadaNext: Junio C Hamano
Message 2 of 6 in “fix global bash variable on __gitcompappend”
  1. fix global bash variable on __gitcompappendMárcio Almada, Apr 8, 2015
  2. fix global bash variable leak on __gitcompappendMárcio Almada, Apr 8, 2015
  3. Junio C HamanoApr 9, 2015
  4. SZEDER GáborApr 9, 2015
  5. Marcio AlmadaApr 9, 2015
  6. Eric SunshineApr 9, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.