From: Eric Sunshine Date: Thu, 09 Apr 2015 19:26:50 GMT Subject: Re: [PATCH] fix global bash variable leak on __gitcompappend Message-ID: In-Reply-To: On Thu, Apr 9, 2015 at 9:52 AM, Marcio Almada wrote: > 2015-04-09 0:56 GMT-03:00 Junio C Hamano : >> "Márcio Almada" writes: >>> contrib/completion/git-completion.bash | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> Nicely found and corrected. Please sign-off your patch and Cc area >> experts if you can find them (I'll do that this time for you). > > Ok, I'll remember this next time. Thanks for your incredible work here. Junio's implication was that you should reply to his message with: Signed-off-by: Your Name Or re-send the patch with your sign-off added.