Re: [RFC PATCH v2 04/13] walken: add handler to git_config
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Jun 27, 2019, 04:54 UTC
- Message-ID
- <CAPig+cT4=qMers5QTGCCPJx9=ej6rPUHjA94SqChxXBdJDTdmg@mail.gmail.com>
- In-Reply-To
- <20190626235032.177551-5-emilyshaffer@google.com>
On Wed, Jun 26, 2019 at 7:51 PM Emily Shaffer <emilyshaffer@google.com> wrote:
Show 19 quoted lines
> For now, we have no configuration options we want to set up for
> ourselves, but in the future we may need to. At the very least, we
> should invoke git_default_config() for each config option; we will do so
> inside of a skeleton config callback so that we know where to add
> configuration handling later on when we need it.
>
> Signed-off-by: Emily Shaffer <emilyshaffer@google.com>
> ---
> diff --git a/builtin/walken.c b/builtin/walken.c
> @@ -24,11 +25,36 @@ const char * const walken_usage[] = {
> static void init_walken_defaults(void)
> {
> /*
> - * We don't actually need the same components `git log` does; leave this
> - * empty for now.
> + * We don't use any other components or have settings to initialize, so
> + * leave this empty.
> */
> }Meh, I don't think this change has anything to do with this patch. If the rewritten text is the one you prefer, then just introduce it like that in patch 3/13 where the function itself was introduced.