[RFC PATCH v3 07/13] walken: filter for authors from gmail address
- From
Emily Shaffer <emilyshaffer@google.com>
- Date
- Jul 1, 2019, 20:20 UTC
- Message-ID
- <20190701202014.34480-8-emilyshaffer@google.com>
- In-Reply-To
- <20190701202014.34480-1-emilyshaffer@google.com>
In order to demonstrate how to create grep filters for revision walks, filter the walk performed by cmd_walken() to print only commits which are authored by someone with a gmail address.
This commit demonstrates how to append a grep pattern to a rev_info.grep_filter, to teach new contributors how to create their own more generalized grep filters during revision walks.
Signed-off-by: Emily Shaffer <emilyshaffer@google.com> --- builtin/walken.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/builtin/walken.c b/builtin/walken.c index f116bb6fca..a600f88cf6 100644 --- a/builtin/walken.c +++ b/builtin/walken.c @@ -11,6 +11,7 @@ #include "parse-options.h" #include "pretty.h" #include "line-log.h" +#include "grep.h" /* @@ -20,10 +21,8 @@ */ static void init_walken_defaults(void) { - /* - * We don't use any other components or have settings to initialize, so - * leave this empty. - */ + /* Needed by our grep filter. */ + init_grep_defaults(the_repository); } /* @@ -55,6 +54,10 @@ static void final_rev_info_setup(int argc, const char **argv, const char *prefix /* add the HEAD to pending so we can start */ add_head_to_pending(rev); + /* Apply a 'grep' pattern to the 'author' header. */ + append_header_grep_pattern(&rev->grep_filter, GREP_HEADER_AUTHOR, "gmail"); + compile_grep_patterns(&rev->grep_filter); + /* Let's force oneline format. */ get_commit_format("oneline", rev); rev->verbose_header = 1; @@ -78,10 +81,7 @@ static void final_rev_info_setup(int argc, const char **argv, const char *prefix */ static int git_walken_config(const char *var, const char *value, void *cb) { - /* - * For now, we don't have any custom configuration, so fall back on the - * default config. - */ + grep_config(var, value, cb); return git_default_config(var, value, cb); }
-- 2.22.0.410.gd8fdbe21b5-goog