Re: [RFC PATCH v2 07/13] walken: filter for authors from gmail address

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Jun 27, 2019, 05:20 UTC
Message-ID: <CAPig+cQQCXA-WsbQrC6XoejjF-roqhmcB7iVH1nA+zUDYTN3vQ@mail.gmail.com>
In-Reply-To: <20190626235032.177551-8-emilyshaffer@google.com>

On Wed, Jun 26, 2019 at 7:51 PM Emily Shaffer <emilyshaffer@google.com> wrote:

Show 9 quoted lines

> In order to demonstrate how to create grep filters for revision walks,
> filter the walk performed by cmd_walken() to print only commits which
> are authored by someone with a gmail address.
> [...]
> Signed-off-by: Emily Shaffer <emilyshaffer@google.com>
> ---
> diff --git a/builtin/walken.c b/builtin/walken.c
> @@ -60,6 +59,10 @@ static void final_rev_info_setup(int argc, const char **argv, const char *prefix
> +       /* Add a grep pattern to the author line in the header. */

This sounds as if we are adding something to the author line, which is confusing. Maybe say instead:

    /* Apply a 'grep' pattern to the author header. */

> +       append_header_grep_pattern(&rev->grep_filter, GREP_HEADER_AUTHOR, "gmail");
> +       compile_grep_patterns(&rev->grep_filter);