Re: [PATCH v2 1/2] sendemail: teach git-send-email to list aliases

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Nov 16, 2015, 23:50 UTC
Message-ID: <CAPig+cSMW2UmTzuyvBFpcpr4tF1FRdxHUPH4+wS3vrZSP9AzJA@mail.gmail.com>
In-Reply-To: <1447717227.23262.10.camel@intel.com>

On Mon, Nov 16, 2015 at 6:40 PM, Keller, Jacob E <jacob.e.keller@intel.com> wrote:

Show 14 quoted lines

> On Mon, 2015-11-16 at 18:30 -0500, Eric Sunshine wrote:
>> Also, is it possible that some consumer down the road might want
>> richer output which includes the expansion of each alias? For
>> instance, it could emit the alias name as the first token on each
>> line
>> and the expansion as the remainder. Consumers interested in only the
>> alias name would grab the first token on the line and ignore
>> everything else.
>
> Maybe? The problem with printing the full address is that it may not be
> quoted or similar, and it makes the bash completion require an extra
> parameter.. I am not sure how valuable the alias expansion would be for
> use? The main concern I have is we'd need to use another process on top
> to extract only alias names.

It should be possible to extract the alias within the shell itself without a separate process. For instance:

    read alias rest

will leave the first token in $alias and the remainder of the line in $rest, and it's all done within the shell process.

Show 5 quoted lines

>> New test(s) seem to be missing.
>
> I had removed the tests from the old version because they weren't
> necessary anymore. New ones wouldn't hurt here either, though.. I'll
> work on that.

I'm not sure which tests you mean, but I was referring to tests to make sure that git-send-email recognizes --list-aliases (or --dump-aliases if you switch to that) and that it produces the expected output in the expected format.

Also, shouldn't --list-aliases (or --dump-aliases) be mutually exclusive with many of the other options? New tests would check such exclusivity as well.