Re: [PATCH v2 1/2] sendemail: teach git-send-email to list aliases

From: Keller, Jacob E <jacob.e.keller@intel.com>
Date: Nov 17, 2015, 00:09 UTC
Message-ID: <1447718958.23262.15.camel@intel.com>
In-Reply-To: <CAPig+cR2t9w6x4YX6Fuc6sk6VMpMU=gfF4GaTz_3a47Px6mwPg@mail.gmail.com>

On Mon, 2015-11-16 at 18:56 -0500, Eric Sunshine wrote:

Show 16 quoted lines

> On Mon, Nov 16, 2015 at 6:50 PM, Eric Sunshine <sunshine@sunshineco.c
> om> wrote:
> > Also, shouldn't --list-aliases (or --dump-aliases) be mutually
> > exclusive with many of the other options? New tests would check
> > such
> > exclusivity as well.
> 
> In fact, while I agree with Szeder that it makes sense to re-use
> send-email's aliases parsing functionality (and was going to suggest
> the same, but he beat me to it), this new option is awfully
> orthogonal
> to the overall purpose of send-email, thus, doesn't really fit in
> well
> and almost cries out for a command of its own which would be used by
> send-email and bash completion (though I'm not convinced that it's
> worth going that route for this one minor use-case).

I don't think it's worth it at this point, because we'd have to extract out the alias parsing logic from send-email, which is not easy.

The option is pretty orthogonal to git-send-email, but until/unless git-send-email is re-implemented in C, i don't really see value in trying to separate the logic out... That is a lot more effort for very little gain.

Regards, Jake