Re: [PATCH v2 2/2] completion: add support for completing email aliases

From: Keller, Jacob E <jacob.e.keller@intel.com>
Date: Nov 16, 2015, 23:40 UTC
Message-ID: <1447717246.23262.11.camel@intel.com>
In-Reply-To: <CAPig+cST4iGdv0B91C_sWs85OMyw5c77ivjZ50xkbF+_uTr1YA@mail.gmail.com>

On Mon, 2015-11-16 at 18:33 -0500, Eric Sunshine wrote:

Show 20 quoted lines

> On Sun, Nov 15, 2015 at 3:22 PM, Jacob Keller <jacob.e.keller@intel.c
> om> wrote:
> > Using the new --list-aliases option from git-send-email, add
> > completion
> > for --to, --cc, and --bcc with the available configured aliases.
> > 
> > Signed-off-by: Jacob Keller <jacob.keller@gmail.com>
> > ---
> > diff --git a/contrib/completion/git-completion.bash
> > b/contrib/completion/git-completion.bash
> > @@ -1711,6 +1712,15 @@ __git_send_email_suppresscc_options="author
> > self cc bodycc sob cccmd body all"
> > 
> >  _git_send_email ()
> >  {
> > +       case "$prev" in
> > +       --to|--cc|--bcc)
> 
> What about --from, which also undergoes alias expansion?
>

Makes sense, yep.