Re: [PATCH v2 1/2] sendemail: teach git-send-email to list aliases
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Nov 16, 2015, 23:56 UTC
- Message-ID
- <CAPig+cR2t9w6x4YX6Fuc6sk6VMpMU=gfF4GaTz_3a47Px6mwPg@mail.gmail.com>
- In-Reply-To
- <CAPig+cSMW2UmTzuyvBFpcpr4tF1FRdxHUPH4+wS3vrZSP9AzJA@mail.gmail.com>
On Mon, Nov 16, 2015 at 6:50 PM, Eric Sunshine <sunshine@sunshineco.com> wrote:
> Also, shouldn't --list-aliases (or --dump-aliases) be mutually > exclusive with many of the other options? New tests would check such > exclusivity as well.
In fact, while I agree with Szeder that it makes sense to re-use send-email's aliases parsing functionality (and was going to suggest the same, but he beat me to it), this new option is awfully orthogonal to the overall purpose of send-email, thus, doesn't really fit in well and almost cries out for a command of its own which would be used by send-email and bash completion (though I'm not convinced that it's worth going that route for this one minor use-case).