Re: [PATCH v2 1/2] sendemail: teach git-send-email to list aliases
- From
Keller, Jacob E <jacob.e.keller@intel.com>
- Date
- Nov 17, 2015, 00:10 UTC
- Message-ID
- <1447719035.23262.17.camel@intel.com>
- In-Reply-To
- <CAPig+cSMW2UmTzuyvBFpcpr4tF1FRdxHUPH4+wS3vrZSP9AzJA@mail.gmail.com>
On Mon, 2015-11-16 at 18:50 -0500, Eric Sunshine wrote:
Show 8 quoted lines
> It should be possible to extract the alias within the shell itself > without a separate process. For instance: > > read alias rest > > will leave the first token in $alias and the remainder of the line in > $rest, and it's all done within the shell process. >
I'll look into this :)
Show 12 quoted lines
> > > New test(s) seem to be missing. > > > > I had removed the tests from the old version because they weren't > > necessary anymore. New ones wouldn't hurt here either, though.. > > I'll > > work on that. > > I'm not sure which tests you mean, but I was referring to tests to > make sure that git-send-email recognizes --list-aliases (or > --dump-aliases if you switch to that) and that it produces the > expected output in the expected format. >
Yep, I added some in my respin.
> Also, shouldn't --list-aliases (or --dump-aliases) be mutually > exclusive with many of the other options? New tests would check such > exclusivity as well.
I am at a loss for how to do that correctly in the perl. Help would be appreciated here.
Regards, Jak