Re: [PATCH 24/30] subtree: don't let debug and progress output clash
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Apr 24, 2021, 04:54 UTC
- Message-ID
- <CAPig+cSJJ9EXRN4p2MYcMGVe8sCutdZ4NGZYfX+E0mLSuFA6SQ@mail.gmail.com>
- In-Reply-To
- <87v98ca4uf.wl-lukeshu@lukeshu.com>
On Fri, Apr 23, 2021 at 8:44 PM Luke Shumaker <lukeshu@lukeshu.com> wrote:
Show 10 quoted lines
> On Fri, 23 Apr 2021 15:07:12 -0600, Eric Sunshine wrote: > > Makes perfect sense when output is to a terminal, though might be > > annoying for the person who redirects stderr to a file. Just idly > > wondering if it makes sense to take that case into consideration... > > (but maybe it doesn't matter much when someone is working at debugging > > a problem). > > The '%s\r' isn't really useful when written to a file, so this change > is useful in the file case too. I'll add a comment and update the > commit-message.
Ah, right. I didn't pay close enough attention to really notice that the "\r"-terminated line was going to stderr, so ignore that bit in my review comment.