Re: [PATCH 12/30] subtree: don't have loose code outside of a function

From: Luke Shumaker <lukeshu@lukeshu.com>
Date: Apr 23, 2021, 23:37 UTC
Message-ID: <871rb0bmjd.wl-lukeshu@lukeshu.com>
In-Reply-To: <CAPig+cTnqYnxPpcn1GTDOpzb2mHAseA694cc-d3mP0JD7VNU5A@mail.gmail.com>

On Fri, 23 Apr 2021 17:11:11 -0600, Eric Sunshine wrote:

Show 5 quoted lines

> If you happen to re-roll, perhaps update the commit message to include
> a small bit of your explanation (which I've mostly snipped here). The
> last bit about moving `set -- -h` and whatnot closer to the rest of
> the argument parsing -- basically improving encapsulation -- may be
> justification enough for readers.

Whenever I end up explaining something on-list, I assume that I should update either a comment or a commit-message when I re-roll :)

-- 
Happy hacking,
~ Luke Shumaker

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.