Re: [PATCH v3 10/30] subtree: t7900: add a test for the -h flag

From: Luke Shumaker <lukeshu@lukeshu.com>
Date: Apr 30, 2021, 16:48 UTC
Message-ID: <87fsz7pvk5.wl-lukeshu@lukeshu.com>
In-Reply-To: <565bbf80-9bdb-699c-ed27-107923e4b94a@gmail.com>

On Fri, 30 Apr 2021 06:22:50 -0600, Bagas Sanjaya wrote:

Show 5 quoted lines

> 
> On 28/04/21 04.17, Luke Shumaker wrote:
> > It's a dumb test, but it's surprisingly easy to break.
> 
> Why did you say that? Very sensitive?

Because I very nearly sent v1 of this patchset with a broken '-h' flag :)

I don't recall for certain, but I think the mistake I made was allowing the ordering of `eval "$(echo "$OPTS_SPEC" | git rev-parse --parseopt -- "$@")"` and `. git-sh-setup` to get flipped. That certainly will break '-h', anyway.

-- 
Happy hacking,
~ Luke Shumaker

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.