Re: [PATCH v2 04/30] subtree: t7900: use consistent formatting

From: Luke Shumaker <lukeshu@lukeshu.com>
Date: Apr 26, 2021, 19:57 UTC
Message-ID: <87o8e0akeb.wl-lukeshu@lukeshu.com>
In-Reply-To: <20210426174525.3937858-5-lukeshu@lukeshu.com>

On Mon, 26 Apr 2021 11:44:59 -0600, Luke Shumaker wrote:

Show 23 quoted lines

> @@ -50,15 +46,17 @@ undo()
>  # The original set of commits changed only one file each.
>  # A multi-file change would imply that we pruned commits
>  # too aggressively.
> -join_commits()
> -{
> +join_commits () {
>  	commit=
>  	all=
>  	while read x y; do
> -		if [ -z "$x" ]; then
> +		if test -z "$x"
> +		then
>  			continue
> -		elif [ "$x" = "commit:" ]; then
> -			if [ -n "$commit" ]; then
> +		elif test "$x" = "commit:"
> +		then
> +			if test -n "$commit"
> +			then
>  				echo "$commit $all"
>  				all=
>  			fi

Whoops, I should have changed those 1-line `while ...; do`'s, in addition to the 1-line `if ...; then`'s.

-- 
Happy hacking,
~ Luke Shumaker

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.