Re: [PATCH v3 0/4] Maintenance IV: Platform-specific background maintenance
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Nov 13, 2020, 20:47 UTC
- Message-ID
- <CAPig+cRPKZGR0XKv4vwtP-xpzYDpB6PL-=Q7weeWtTbDG7o3vQ@mail.gmail.com>
- In-Reply-To
- <pull.776.v3.git.1605276024.gitgitgadget@gmail.com>
On Fri, Nov 13, 2020 at 9:00 AM Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com> wrote:
> * This actually includes the feedback responses I had intended for v2. > Sorry about that!
I forgot to mention a couple things when reviewing the patches individually, so I'll point them out here...
> + at [2]. The current design does not preclude a future version that > + detects the available fatures of 'launchctl' to use the older
s/fatures/features/
> -+ test_cmp expect args > ++ test_line_count = 0 actual
These days, we usually say:
test_must_be_empty actual