Re: [PATCH v4 2/4] maintenance: include 'cron' details in docs
- From
Derrick Stolee <stolee@gmail.com>
- Date
- Nov 18, 2020, 18:30 UTC
- Message-ID
- <6bd1b36f-48fe-c27d-3917-899a9b28eef3@gmail.com>
- In-Reply-To
- <CAPig+cQw=hBqp2jSOOKNCKMe7bUFFLqT2fi0iaBfth-4x7RTgQ@mail.gmail.com>
On 11/17/2020 7:34 PM, Eric Sunshine wrote:
Show 34 quoted lines
> On Tue, Nov 17, 2020 at 4:13 PM Derrick Stolee via GitGitGadget > <gitgitgadget@gmail.com> wrote: >> Advanced and expert users may want to know how 'git maintenance start' >> schedules background maintenance in order to customize their own >> schedules beyond what the maintenance.* config values allow. Start a new >> set of sections in git-maintenance.txt that describe how 'cron' is used >> to run these tasks. >> >> This is particularly valuable for users who want to inspect what Git is >> doing or for users who want to customize the schedule further. Having a >> baseline can provide a way forward for users who have never worked with >> cron schedules. >> >> Signed-off-by: Derrick Stolee <dstolee@microsoft.com> >> --- >> diff --git a/Documentation/git-maintenance.txt b/Documentation/git-maintenance.txt >> @@ -218,6 +218,60 @@ Further, the `git gc` command should not be combined with >> +The comments are used as a region to mark the schedule as written by Git. >> +Any modifications within this region will be completely deleted by >> +`git maintenance stop` or overwritten by `git maintenance start`. >> + >> +The `<path>` string is loaded to specifically use the location for the >> +`git` executable used in the `git maintenance start` command. This allows >> +for multiple versions to be compatible. However, if the same user runs >> +`git maintenance start` with multiple Git executables, then only the >> +latest executable will be used. > > It looks like this section in v4 got accidentally reverted to the > wording from v2, whereas v3 had been changed to:> > The `crontab` entry specifies the full path of the `git` > executable to ensure that the executed `git` command is the same > one with which `git maintenance start` was issued independent of > `PATH`. If the same user runs `git maintenance start` with > multiple Git executables, then only the latest executable is used.
Embarassing. Thanks for the catch.
Thanks, -Stolee