git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v7 3/4] maintenance: use launchctl on macOS

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Jan 10, 2021, 06:34 UTC
Message-ID
<CAPig+cRBK778CTj1mbg03HOcCCZXn9v+FLDkhA0ho+wd=GTCNQ@mail.gmail.com>
In-Reply-To
<3576c7aa54e08c11ac86675ca9bc11b80366d390.1609852109.git.gitgitgadget@gmail.com>

On Tue, Jan 5, 2021 at 8:08 AM Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com> wrote:

Show 9 quoted lines
> [...]
> The need for a user id requires us to run 'id -u' which works on
> POSIX systems but not Windows. Further, the need for fully-qualitifed
> path names including $HOME behaves differently in the Git internals and
> the external test suite. The $HOME variable starts with "C:\..." instead
> of the "/c/..." that is provided by Git in these subcommands. The test
> therefore has a prerequisite that we are not on Windows. The cross-
> platform logic still allows us to test the macOS logic on a Linux
> machine.
You forgot to remove the above paragraph...
Show 11 quoted lines
> We strive to make these tests work on all platforms, but Windows caused
> some headaches. In particular, the value of getuid() called by the C
> code is not guaranteed to be the same as `$(id -u)` invoked by a test.
> This is because `git.exe` is a native Windows program, whereas the
> utility programs run by the test script mostly utilize the MSYS2 runtime,
> which emulates a POSIX-like environment. Since the purpose of the test
> is to check that the input to the hook is well-formed, the actual user
> ID is immaterial, thus we can work around the problem by making the the
> test UID-agnostic. Another subtle issue is the $HOME environment
> variable being a Windows-style path instead of a Unix-style path. We can
> be more flexible here instead of expecting exact path matches.

...when you added this paragraph from my separate patch which you folded into this patch for v7. The two paragraphs are at odds with one another.

Previous: Derrick Stolee via GitGitGadget
Message 83 of 83 in “Maintenance IV: Platform-specific background maintenance”
  1. 0/3 Maintenance IV: Platform-specific background maintenanceDerrick Stolee via GitGitGadget, Nov 3, 2020
  2. 1/3 maintenance: extract platform-specific schedulingDerrick Stolee via GitGitGadget, Nov 3, 2020
  3. 3/3 maintenance: use Windows scheduled tasksDerrick Stolee via GitGitGadget, Nov 3, 2020
  4. Eric SunshineNov 3, 2020
  5. Derrick StoleeNov 3, 2020
  6. 2/3 maintenance: use launchctl on macOSDerrick Stolee via GitGitGadget, Nov 3, 2020
  7. Eric SunshineNov 3, 2020
  8. Derrick StoleeNov 3, 2020
  9. Eric SunshineNov 3, 2020
  10. Derrick StoleeNov 4, 2020
  11. Derrick StoleeNov 4, 2020
  12. Junio C HamanoNov 3, 2020
  13. Junio C HamanoNov 3, 2020
  14. Derrick StoleeNov 3, 2020
  15. Junio C HamanoNov 3, 2020
  16. Derrick StoleeNov 4, 2020
  17. Junio C HamanoNov 4, 2020
  18. Derrick StoleeNov 4, 2020
  19. 0/4 Maintenance IV: Platform-specific background maintenanceDerrick Stolee via GitGitGadget, Nov 4, 2020
  20. 3/4 maintenance: use launchctl on macOSDerrick Stolee via GitGitGadget, Nov 4, 2020
  21. Eric SunshineNov 11, 2020
  22. Derrick StoleeNov 12, 2020
  23. Eric SunshineNov 12, 2020
  24. 2/4 maintenance: include 'cron' details in docsDerrick Stolee via GitGitGadget, Nov 4, 2020
  25. Eric SunshineNov 11, 2020
  26. 4/4 maintenance: use Windows scheduled tasksDerrick Stolee via GitGitGadget, Nov 4, 2020
  27. Eric SunshineNov 11, 2020
  28. Derrick StoleeNov 12, 2020
  29. 1/4 maintenance: extract platform-specific schedulingDerrick Stolee via GitGitGadget, Nov 4, 2020
  30. 0/4 Maintenance IV: Platform-specific background maintenanceDerrick Stolee via GitGitGadget, Nov 13, 2020
  31. 1/4 maintenance: extract platform-specific schedulingDerrick Stolee via GitGitGadget, Nov 13, 2020
  32. 2/4 maintenance: include 'cron' details in docsDerrick Stolee via GitGitGadget, Nov 13, 2020
  33. 3/4 maintenance: use launchctl on macOSDerrick Stolee via GitGitGadget, Nov 13, 2020
  34. Eric SunshineNov 13, 2020
  35. Derrick StoleeNov 13, 2020
  36. Eric SunshineNov 13, 2020
  37. Eric SunshineNov 13, 2020
  38. 4/4 maintenance: use Windows scheduled tasksDerrick Stolee via GitGitGadget, Nov 13, 2020
  39. Eric SunshineNov 13, 2020
  40. Derrick StoleeNov 13, 2020
  41. Eric SunshineNov 13, 2020
  42. Derrick StoleeNov 16, 2020
  43. Eric SunshineNov 13, 2020
  44. Eric SunshineNov 14, 2020
  45. Derrick StoleeNov 16, 2020
  46. 0/4 Maintenance IV: Platform-specific background maintenanceDerrick Stolee via GitGitGadget, Nov 17, 2020
  47. 1/4 maintenance: extract platform-specific schedulingDerrick Stolee via GitGitGadget, Nov 17, 2020
  48. 2/4 maintenance: include 'cron' details in docsDerrick Stolee via GitGitGadget, Nov 17, 2020
  49. Eric SunshineNov 18, 2020
  50. Derrick StoleeNov 18, 2020
  51. 3/4 maintenance: use launchctl on macOSDerrick Stolee via GitGitGadget, Nov 17, 2020
  52. Eric SunshineNov 18, 2020
  53. Derrick StoleeNov 18, 2020
  54. 4/4 maintenance: use Windows scheduled tasksDerrick Stolee via GitGitGadget, Nov 17, 2020
  55. Eric SunshineNov 18, 2020
  56. Derrick StoleeNov 18, 2020
  57. Eric SunshineNov 18, 2020
  58. Derrick StoleeNov 18, 2020
  59. Eric SunshineNov 17, 2020
  60. Derrick StoleeNov 24, 2020
  61. Eric SunshineNov 24, 2020
  62. Eric SunshineNov 17, 2020
  63. 0/4 Maintenance IV: Platform-specific background maintenanceDerrick Stolee via GitGitGadget, Nov 24, 2020
  64. 1/4 maintenance: extract platform-specific schedulingDerrick Stolee via GitGitGadget, Nov 24, 2020
  65. 2/4 maintenance: include 'cron' details in docsDerrick Stolee via GitGitGadget, Nov 24, 2020
  66. 4/4 maintenance: use Windows scheduled tasksDerrick Stolee via GitGitGadget, Nov 24, 2020
  67. Eric SunshineNov 27, 2020
  68. 3/4 maintenance: use launchctl on macOSDerrick Stolee via GitGitGadget, Nov 24, 2020
  69. 0/4 Maintenance IV: Platform-specific background maintenanceDerrick Stolee via GitGitGadget, Dec 9, 2020
  70. 2/4 maintenance: include 'cron' details in docsDerrick Stolee via GitGitGadget, Dec 9, 2020
  71. 1/4 maintenance: extract platform-specific schedulingDerrick Stolee via GitGitGadget, Dec 9, 2020
  72. 4/4 maintenance: use Windows scheduled tasksDerrick Stolee via GitGitGadget, Dec 9, 2020
  73. 3/4 maintenance: use launchctl on macOSDerrick Stolee via GitGitGadget, Dec 9, 2020
  74. Junio C HamanoDec 10, 2020
  75. Eric SunshineDec 10, 2020
  76. Junio C HamanoDec 10, 2020
  77. Derrick StoleeJan 5, 2021
  78. 0/4 Maintenance IV: Platform-specific background maintenanceDerrick Stolee via GitGitGadget, Jan 5, 2021
  79. 2/4 maintenance: include 'cron' details in docsDerrick Stolee via GitGitGadget, Jan 5, 2021
  80. 1/4 maintenance: extract platform-specific schedulingDerrick Stolee via GitGitGadget, Jan 5, 2021
  81. 4/4 maintenance: use Windows scheduled tasksDerrick Stolee via GitGitGadget, Jan 5, 2021
  82. 3/4 maintenance: use launchctl on macOSDerrick Stolee via GitGitGadget, Jan 5, 2021
  83. Eric SunshineJan 10, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.