Re: [PATCH v3 2/4] t/t7030-verify-tag.sh: Adds validation for multiple tags

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Apr 3, 2016, 07:59 UTC
Message-ID: <CAPig+cQp2t0y7imR5tTHdLdMO6w13ia-GxZXxq4c2NGaZTjErw@mail.gmail.com>
In-Reply-To: <20160403044054.GB1519@sigill.intra.peff.net>

On Sun, Apr 3, 2016 at 12:40 AM, Jeff King <peff@peff.net> wrote:

Show 12 quoted lines

> In fact, I suspect you could replace the "GOODSIG" check as well by
> doing something like:
>
>   # verifying 3 tags in one invocation should be exactly like
>   # verifying the 3 separately
>   tags="fourth-signed sixth-signed seventh-signed"
>   for i in $tags; do
>           git verify-tag -v --raw $i || return 1
>   done >expect.stdout 2>expect.stderr &&
>   git verify-tag -v --raw $tags >actual.stdout 2>actual.stderr &&
>   test_cmp expect.stdout actual.stdout &&
>   test_cmp expect.stderr actual.stderr

Hmm, does [1] suggest that using test_cmp on stderr here would be contraindicated?

[1]: http://article.gmane.org/gmane.comp.version-control.git/289077