git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 0/4] tag: move PGP verification code to tag.c

From
santiago@nyu.edu <santiago@nyu.edu>
Date
Apr 2, 2016, 23:16 UTC
Message-ID
<1459638975-17705-1-git-send-email-santiago@nyu.edu>
This is a follow up of [1] and [2]:

v3 (this): Thanks Eric, Jeff, for the feedback.

 * I separated the patch in multiple sub-patches.
 * I compared the behavior of previous git tag -v and git verify-tag 
   invocations to make sure the behavior is the same
 * I dropped the multi-line comment, as suggested.
 * I fixed the issue with the missing brackets in the while (this is 
   now detected by the test).
v2:
 * I moved the pgp-verification code to tag.c 
 * I added extra arguments so git tag -v and git verify-tag both work
   with the same function
 * Relocated the SIGPIPE handling code in verify-tag to gpg-interface
v1:
 
The verify tag function is just a thin wrapper around the verify-tag
command. We can avoid one fork call by doing the verification inside
the tag builtin instead.
This applies on v2.8.0.

Thanks! -Santiago

[1] http://git.661346.n2.nabble.com/PATCH-RFC-builtin-tag-c-move-PGP-verification-inside-builtin-td7651529.html#a7651547 [2] http://git.661346.n2.nabble.com/PATCH-tag-c-move-PGP-verification-code-from-plumbing-td7651562.html

Next: santiago@nyu.edu
Message 1 of 24 in “tag: move PGP verification code to tag.c”
  1. 0/4 tag: move PGP verification code to tag.csantiago@nyu.edu, Apr 2, 2016
  2. 1/4 builtin/verify-tag.c: Ignore SIGPIPE on gpg-interfacesantiago@nyu.edu, Apr 2, 2016
  3. Jeff KingApr 3, 2016
  4. Johannes SixtApr 3, 2016
  5. Santiago TorresApr 3, 2016
  6. 2/4 t/t7030-verify-tag.sh: Adds validation for multiple tagssantiago@nyu.edu, Apr 2, 2016
  7. Jeff KingApr 3, 2016
  8. Eric SunshineApr 3, 2016
  9. Jeff KingApr 3, 2016
  10. Santiago TorresApr 3, 2016
  11. Eric SunshineApr 4, 2016
  12. Jeff KingApr 4, 2016
  13. 3/4 builtin/verify-tag: move verification code to tag.csantiago@nyu.edu, Apr 2, 2016
  14. Jeff KingApr 3, 2016
  15. Eric SunshineApr 3, 2016
  16. Eric SunshineApr 3, 2016
  17. Santiago TorresApr 3, 2016
  18. 4/4 tag: use pgp_verify_function in tag -v callsantiago@nyu.edu, Apr 2, 2016
  19. Jeff KingApr 3, 2016
  20. Santiago TorresApr 3, 2016
  21. Santiago TorresApr 4, 2016
  22. Jeff KingApr 4, 2016
  23. Santiago TorresApr 4, 2016
  24. Jeff KingApr 4, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.