[PATCH v3 0/4] tag: move PGP verification code to tag.c
- From
santiago@nyu.edu <santiago@nyu.edu>
- Date
- Apr 2, 2016, 23:16 UTC
- Message-ID
- <1459638975-17705-1-git-send-email-santiago@nyu.edu>
This is a follow up of [1] and [2]:
v3 (this): Thanks Eric, Jeff, for the feedback.
* I separated the patch in multiple sub-patches. * I compared the behavior of previous git tag -v and git verify-tag invocations to make sure the behavior is the same * I dropped the multi-line comment, as suggested. * I fixed the issue with the missing brackets in the while (this is now detected by the test).
v2:
* I moved the pgp-verification code to tag.c * I added extra arguments so git tag -v and git verify-tag both work with the same function * Relocated the SIGPIPE handling code in verify-tag to gpg-interface
v1: The verify tag function is just a thin wrapper around the verify-tag command. We can avoid one fork call by doing the verification inside the tag builtin instead.
This applies on v2.8.0.
Thanks! -Santiago
[1] http://git.661346.n2.nabble.com/PATCH-RFC-builtin-tag-c-move-PGP-verification-inside-builtin-td7651529.html#a7651547 [2] http://git.661346.n2.nabble.com/PATCH-tag-c-move-PGP-verification-code-from-plumbing-td7651562.html