Re: [PATCH v3 2/4] t/t7030-verify-tag.sh: Adds validation for multiple tags

From: Jeff King <peff@peff.net>
Date: Apr 3, 2016, 13:07 UTC
Message-ID: <20160403130724.GA16206@sigill.intra.peff.net>
In-Reply-To: <CAPig+cQp2t0y7imR5tTHdLdMO6w13ia-GxZXxq4c2NGaZTjErw@mail.gmail.com>

On Sun, Apr 03, 2016 at 03:59:46AM -0400, Eric Sunshine wrote:

Show 18 quoted lines

> On Sun, Apr 3, 2016 at 12:40 AM, Jeff King <peff@peff.net> wrote:
> > In fact, I suspect you could replace the "GOODSIG" check as well by
> > doing something like:
> >
> >   # verifying 3 tags in one invocation should be exactly like
> >   # verifying the 3 separately
> >   tags="fourth-signed sixth-signed seventh-signed"
> >   for i in $tags; do
> >           git verify-tag -v --raw $i || return 1
> >   done >expect.stdout 2>expect.stderr &&
> >   git verify-tag -v --raw $tags >actual.stdout 2>actual.stderr &&
> >   test_cmp expect.stdout actual.stdout &&
> >   test_cmp expect.stderr actual.stderr
> 
> Hmm, does [1] suggest that using test_cmp on stderr here would be
> contraindicated?
> 
> [1]: http://article.gmane.org/gmane.comp.version-control.git/289077

It does, but I am not sure I agree with the advice in that email in the general case (I like making "-x" work, too, but not at the cost of making the tests harder to read and write). In this case, I suppose you could grep for gpg raw-output on stderr, though, and compare only that.

-Peff