Re: [PATCH 00/28] Hash-independent tests (part 2)

From: Eric Sunshine <sunshine@sunshineco.com>
Date: May 7, 2018, 01:49 UTC
Message-ID: <CAPig+cQnsdcYQnDB_bvn1p9wc9wTVAPAGZKn6_JHqnRtfAXaUA@mail.gmail.com>
In-Reply-To: <20180506231752.975110-1-sandals@crustytoothpaste.net>

On Sun, May 6, 2018 at 7:17 PM, brian m. carlson <sandals@crustytoothpaste.net> wrote:

Show 12 quoted lines

> This series introduces an SHA1 prerequisite which checks if the hash in
> use is SHA-1, and can be used to skip the test if it is not.
> Additionally, because NewHash will be 256-bit, I introduced aliases for
> the test constants $_x40 and $_z40 which will be less confusing when the
> hash isn't 40 hex characters long.  I opted to leave the old names in
> place for the moment to prevent any potential conflicts with other
> series and will clean up any stragglers later.
>
> Several tests are skipped because of SHA-1-specific dependencies: some
> of these are core tests which test basic expected hash values, some
> depend on colliding short names, and some depend on specially named
> object (the pack tests).

Was I wrong to expect this series to annotate[1] tests

    t3404 "short SHA-1 setup"
    t3404 "short SHA-1 collide"

with the SHA1 prerequisite?

[1]: https://public-inbox.org/git/CAPig+cR==SNfGdhwqPdvW75fUxXg-VSQ5Tz_OR7Sy_c0L94axQ@mail.gmail.com/T/#m7bb98bd57a3189bb5fe01993b22b0c480a601259