Re: [PATCH 16/28] t4008: abstract away SHA-1-specific constants

From: Eric Sunshine <sunshine@sunshineco.com>
Date: May 7, 2018, 00:07 UTC
Message-ID: <CAPig+cQ0tm76B4_uewtdMwUo9weRkz92id5cuuQcRdBByZBCDA@mail.gmail.com>
In-Reply-To: <20180506231752.975110-17-sandals@crustytoothpaste.net>

On Sun, May 6, 2018 at 7:17 PM, brian m. carlson <sandals@crustytoothpaste.net> wrote:

Show 11 quoted lines

> Adjust the test so that it computes variables for blobs instead of using
> hard-coded hashes.
>
> Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
> ---
> diff --git a/t/t4008-diff-break-rewrite.sh b/t/t4008-diff-break-rewrite.sh
> @@ -27,29 +27,32 @@ Further, with -B and -M together, these should turn into two renames.
> +       blob0_id=$(git hash-object file0) &&
> +       blob1_id=$(git hash-object file1) &&
> +       blob2_id=$(git hash-object file1) &&
> +       link_oid=$(printf frotz | git hash-object --stdin) &&

Inconsistency nit: For the blobs, you tacked on "_id" but for the link you added "_oid".