Re: [PATCH 14/28] t3905: abstract away SHA-1-specific constants

From: Eric Sunshine <sunshine@sunshineco.com>
Date: May 7, 2018, 00:03 UTC
Message-ID: <CAPig+cQ7hn_P_xZW70X4vCztCr_r84+ofh_ApEbZwfQKRRq6Nw@mail.gmail.com>
In-Reply-To: <20180506231752.975110-15-sandals@crustytoothpaste.net>

On Sun, May 6, 2018 at 7:17 PM, brian m. carlson <sandals@crustytoothpaste.net> wrote:

Show 13 quoted lines

> Adjust the test so that it computes variables for blobs instead of using
> hard-coded hashes.
>
> Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
> ---
> diff --git a/t/t3905-stash-include-untracked.sh b/t/t3905-stash-include-untracked.sh
> @@ -34,25 +34,26 @@ test_expect_success 'stash save --include-untracked cleaned the untracked files'
>         git status --porcelain >actual &&
>         test_cmp expect actual
>  '
> -
> +tracked=$(git rev-parse --short $(echo 1 | git hash-object --stdin))
> +untracked=$(git rev-parse --short $(echo untracked | git hash-object --stdin))

You lost the blank line following the previous test.

Show 7 quoted lines

>  cat > expect.diff <<EOF
>  diff --git a/HEAD b/HEAD
>  new file mode 100644
> -index 0000000..d00491f
> +index 0000000..$tracked
>  --- /dev/null
>  +++ b/HEAD