git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/2] fsmonitor: fixup to avoid warnings from pedantic

From
Carlo Arenas <carenas@gmail.com>
Date
Aug 28, 2021, 09:45 UTC
Message-ID
<CAPUEspgDbi1v32p+H=afZSDVOo_VpJzKn7bU8_s+fPJxm=mtBQ@mail.gmail.com>
In-Reply-To
<xmqq1r6ebyo5.fsf@gitster.g>
On Fri, Aug 27, 2021 at 10:11 AM Junio C Hamano <gitster@pobox.com> wrote:
Show 5 quoted lines
>
> One thing I noticed is that simple-ipc.h can disable itself
> altogether with "#ifdef SUPPORTS_SIMPLE_IPC", so the unconditional
> use of "enum ipc_active_state" by fsmonitor-ipc.h would still be a
> problem.

That is why we also need an additional patch[1] to be able to build (at least in macOS).

in windows additional changes are required, but I suspect that configuration is probably not expected.

> fsmonitor-ipc.h is included even in help.c so it seems
> that with this topic, you practically will not get a working Git at
> all with -pedantic when SUPPORTS_SIMPLE_IPC is not true.

not sure if I understand the logic here, but there is a "mock" daemon that is used in the platforms that don't have support that will be available then (even if it just refuses to start), and that is still IMHO a working git configuration.

Carlo
[1] https://lore.kernel.org/git/20210817082310.2157-1-carenas@gmail.com/
Previous: Junio C Hamano
Message 13 of 13 in “fsmonitor: fixup to avoid warnings from pedantic”
  1. 0/2 fsmonitor: fixup to avoid warnings from pedanticCarlo Marcelo Arenas Belón, Aug 9, 2021
  2. 1/2 fixup! fsmonitor-ipc: create client routines for git-fsmonitor--daemonCarlo Marcelo Arenas Belón, Aug 9, 2021
  3. 2/2 fixup! fsmonitor--daemon: implement handle_client callbackCarlo Marcelo Arenas Belón, Aug 9, 2021
  4. test-path-utils: use a C89 compatible format for double printfCarlo Marcelo Arenas Belón, Aug 9, 2021
  5. Jeff HostetlerAug 9, 2021
  6. Junio C HamanoAug 9, 2021
  7. Carlo ArenasAug 10, 2021
  8. Jeff HostetlerAug 10, 2021
  9. Jeff HostetlerAug 10, 2021
  10. Junio C HamanoAug 27, 2021
  11. Carlo ArenasAug 27, 2021
  12. Junio C HamanoAug 27, 2021
  13. Carlo ArenasAug 28, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.