Re: [PATCH 0/2] fsmonitor: fixup to avoid warnings from pedantic
- From
- Jeff Hostetler <git@jeffhostetler.com>
- Date
- Aug 10, 2021, 13:41 UTC
- Message-ID
- <b554c82a-4da1-9676-4d93-b769ab6bbcbd@jeffhostetler.com>
- In-Reply-To
- <xmqqpmumftry.fsf@gitster.g>
On 8/9/21 12:49 PM, Junio C Hamano wrote:
Show 26 quoted lines
> Jeff Hostetler <git@jeffhostetler.com> writes: > >> On 8/9/21 2:30 AM, Carlo Marcelo Arenas Belón wrote: >>> seen with both clang 12 and gcc 11 in seen (including jh/builtin-fsmonitor) >>> as of a5a42b9f76 (from Jul 1) >>> it should be squashed into the corresponding patch from the series >>> as shown >>> in the subject and reroll IMHO; notice Junio also has some bandaid sparse >>> fixes for t/helper/test-touch.c that should be included. >>> a similar additional fix for C89 compatibility to be send as a reply >>> later >>> Carlo Marcelo Arenas Belón (2): >>> fixup! fsmonitor-ipc: create client routines for git-fsmonitor--daemon >>> fixup! fsmonitor--daemon: implement handle_client callback >>> builtin/fsmonitor--daemon.c | 2 +- >>> fsmonitor-ipc.h | 2 ++ >>> 2 files changed, 3 insertions(+), 1 deletion(-) >>> >> >> Thanks! > > Thanks, both. > > Jeff, I understand that this is planned to be rerolled post release, > so I'll not touch these fixups and let yuou worry about them ;-) >
Right. I'll include them with my next version. Jeff